Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: system tab -> advanced starts unfolded ......................................................................
webadmin: system tab -> advanced starts unfolded The problem was that the adminOnlyWidgets() contained not only the expander itself but also it's content showing it if the user is an admin user. This is not correct - the visibility has to be controlled by the AdvancedParametersExpander component only and this whole component has to be shown/hidden using the adminOnlyWidgets() Change-Id: Ib5778b4745cda6abd2648074d71f52548b75916e Bug-Url: https://bugzilla.redhat.com/1166048 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/36887/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java index e1f65a7..4bcac5e 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java @@ -2095,7 +2095,6 @@ detachableMemSizeEditor, totalvCPUsEditorWithInfoIcon, vcpusAdvancedParameterExpander, - vcpusAdvancedParameterExpanderContent, serialNumberPolicyEditor, // console tab -- To view, visit http://gerrit.ovirt.org/36887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5778b4745cda6abd2648074d71f52548b75916e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
