Liron Aravot has posted comments on this change. Change subject: core: improve use of updateStorageDomainFormat ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/36804/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java: Line 344: Line 345: protected void updateStorageDomainFormatIfNeeded(StorageDomain domain) { Line 346: final StorageDomainType sdType = domain.getStorageDomainType(); Line 347: Line 348: if (sdType != StorageDomainType.Data && sdType != StorageDomainType.Master) { do you mind to change it to "isDataDomain" if we are already touching it? Line 349: log.debug("Skipping format update for domain '{}' (type '{}')", Line 350: getStorageDomain().getId(), sdType); Line 351: return; Line 352: } -- To view, visit http://gerrit.ovirt.org/36804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a85ed4ef208d1161e8bf0cd436b2e9f036a385 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
