Juan Hernandez has posted comments on this change. Change subject: Added makefile for build system ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36840/3/Makefile File Makefile: Line 2: dist: Line 3: cd ovirt-engine-sdk-java; $(MAKE) dist; mv *.gz ../ Line 4: Line 5: clean: Line 6: cd ovirt-engine-sdk-java; $(MAKE) clean > It is probably irrelevant, but this "clean" target will not remove the *.gz Also, you may want to use the "-C" option of make instead of the additional "cd" command. -- To view, visit http://gerrit.ovirt.org/36840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a06f04ae75b2e3d6f3d2e174e72b8c9a22accd7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
