Arik Hadas has posted comments on this change. Change subject: webadmin: minor cleanup in import vm related code ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36672/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java: Line 526: } Line 527: Line 528: @Override Line 529: public VM getEntity() { Line 530: return (VM) super.getEntity(); > The entity model is generic already - would it be possible to generify also it's a bit problematic since VmImportGeneralModel extends VmGeneralModel and it gets ImportVmData as the entity, so we have to keep setEntity receiving an Object.. Line 531: } Line 532: Line 533: @Override Line 534: protected void onEntityChanged() -- To view, visit http://gerrit.ovirt.org/36672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I390aeb08fc6180b19acb30f6bf17f9d4c3c0d9dd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
