Arik Hadas has posted comments on this change. Change subject: core: do not copy RNG device from instance type if not possible ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/36797/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java: Line 81: Line 82: return true; Line 83: } Line 84: Line 85: // it is here only to make it possible to mock it please replace with documentation comment (/** */) Line 86: protected VirtIoRngValidator getVirtioRngValidator() { Line 87: return new VirtIoRngValidator(); Line 88: } Line 89: http://gerrit.ovirt.org/#/c/36797/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java: Line 23: return false; Line 24: } Line 25: Line 26: if (getTemplateType() != VmEntityType.INSTANCE_TYPE) { Line 27: validate(getVirtioRngValidator().canAddRngDevice(getVdsGroup(), getParameters().getRngDevice())); should return false if the validation fails Line 28: } Line 29: Line 30: if (!getRngDevices().isEmpty()) { Line 31: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_RNG_ALREADY_EXISTS); http://gerrit.ovirt.org/#/c/36797/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java: Line 24: return false; Line 25: } Line 26: Line 27: if (getTemplateType() != VmEntityType.INSTANCE_TYPE) { Line 28: validate(getVirtioRngValidator().canAddRngDevice(getVdsGroup(), getParameters().getRngDevice())); same here, missing return statement Line 29: } Line 30: Line 31: if (getRngDevices().isEmpty()) { Line 32: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_RNG_NOT_FOUND); http://gerrit.ovirt.org/#/c/36797/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java: Line 19: if (supported) { Line 20: return ValidationResult.VALID; Line 21: } Line 22: Line 23: return new ValidationResult(VdcBllMessages.ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL); suggestion: return the ValidationResult if !supported and by-default return VALID. I think it's better as this validator might be extended in the future by adding additional validations so it will be easier to modify it that way. Line 24: } Line 25: Line 26: protected boolean isFeatureSupported(Version clusterVersion) { Line 27: return FeatureSupported.virtIoRngSupported(clusterVersion); -- To view, visit http://gerrit.ovirt.org/36797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic016df28bd0484735c74308750fe03ab9036f59d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
