Eli Mesika has posted comments on this change. Change subject: core: VDS code cleanup ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36681/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 17: import org.ovirt.engine.core.compat.Version; Line 18: Line 19: public class VDS extends IVdcQueryable implements Serializable, BusinessEntityWithStatus<Guid, VDSStatus>, HasStoragePool<Guid>, Commented, Nameable, Cloneable { Line 20: private static final long serialVersionUID = -7893976203379789926L; Line 21: private VdsStatic mVdsStatic; all those variables with 'm' prefix are migrated from .NET and the 'm' should be deleted as part of a cleanup Line 22: private VdsDynamic mVdsDynamic; Line 23: private VdsStatistics mVdsStatistics; Line 24: private ArrayList<VdsNetworkInterface> mInterfaceList; Line 25: private ArrayList<Network> mNetworkList; -- To view, visit http://gerrit.ovirt.org/36681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f042df0710a9785042e199ed1710dbf4e23a94c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
