Vered Volansky has posted comments on this change. Change subject: engine : NPE when adding a VM to a VM pool when there's not enough storage ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36664/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java: Line 124: Step parentStep = context.getStep(); Line 125: if (context.getExecutionMethod() == ExecutionMethod.AsStep Line 126: && parentStep != null) { Line 127: context.setCompleted(true); Line 128: if (!exitStatus && job != null) { I would keep the condition order as in the if on line 116 (or change the order there). The similarity between conditions is more clear this way. Line 129: job.markJobEnded(false); Line 130: JobRepositoryFactory.getJobRepository() Line 131: .updateCompletedJobAndSteps(job); Line 132: } -- To view, visit http://gerrit.ovirt.org/36664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d53e9505054f9476910154a7677d273293f79c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
