Eldan Shachar has posted comments on this change. Change subject: userportal\webadmin: Editing of template version for stateless VMs and pools ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36510/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 1644: Line 1645: object.getTemplateChanged().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { Line 1646: @Override Line 1647: public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { Line 1648: Boolean enabled = object.getTemplateChanged().getEntity(); > why is the new template data not editable? We load the model with the new template data, which may be totally different from the existing VM. if the VM is running this data will be presented until a shutdown occurs so we can't change the running VM and it may be confusing to allow editing of the new version as it's currently irrelevant. this becomes more problematic if 'latest' is used because then the changed data may be discarded when a newer version is available. for powerd-off VMs there are other issues which complicate things but it's probably more feasible. Line 1649: if (Boolean.TRUE.equals(enabled)) { Line 1650: tabsState = getAllTabsState(); Line 1651: disableAllTabs(); Line 1652: templateEditor.setEnabled(tabsState.get(templateEditor)); // if template editing was allowed -> keep it enabled -- To view, visit http://gerrit.ovirt.org/36510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53686dae694f6ff826bdbeaada1e28fc55fd8d30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
