Arik Hadas has posted comments on this change. Change subject: core: notification to the user that a new client tools are available ......................................................................
Patch Set 5: Code-Review+1 (2 comments) looks good. please update the number of the db-script and two minor comments are inside http://gerrit.ovirt.org/#/c/36556/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 956: private static final Pattern ISO_VERSION_PATTERN = Pattern.compile(".*rhev-toolssetup_(\\d\\.\\d\\_\\d).*"); Line 957: Line 958: // Looking for "RHEV_Tools x.x.x" in VMs app_list Line 959: // if found we look if there is a newer version in the isoList - if so Line 960: // we update the GuestAgentStatus of VmDynamic to UpdateNeeded please replace with documentation comment (/** ... */) Line 961: public static void refreshVmsToolsVersion(Guid poolId, Set<String> isoList) { Line 962: String latestVersion = getLatestGuestToolsVersion(isoList); Line 963: if (latestVersion == null) { Line 964: return; Line 982: } Line 983: } Line 984: Line 985: // iso file name that we are looking for: RHEV_toolsSetup_x.x_x.iso Line 986: // returning latest version only: xxx (ie 3.1.2) same here Line 987: private static String getLatestGuestToolsVersion(Set<String> isoList) { Line 988: String latestVersion = null; Line 989: for (String iso: isoList) { Line 990: if (iso.toLowerCase().contains("rhev-toolssetup")) { -- To view, visit http://gerrit.ovirt.org/36556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If098422eb76295517022de1c7f716db354e7853e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
