Moti Asayag has posted comments on this change. Change subject: core: make DbFacade a CDI singleton ......................................................................
Patch Set 32: (3 comments) http://gerrit.ovirt.org/#/c/34814/32/backend/manager/dependencies/common/pom.xml File backend/manager/dependencies/common/pom.xml: Line 377: <groupId>org.codehaus.jackson</groupId> Line 378: <artifactId>jackson-xc</artifactId> Line 379: <version>${jackson.version}</version> Line 380: </dependency> Line 381: please remove tws Line 382: <dependency> Line 383: <groupId>org.apache.deltaspike.core</groupId> Line 384: <artifactId>deltaspike-core-api</artifactId> Line 385: <version>${deltaspike.version}</version> Line 763: <artifactId>deltaspike-core-impl</artifactId> Line 764: <moduleName>org.deltaspike</moduleName> Line 765: </module> Line 766: Line 767: <module> please remove tabs with spaces and format this element Line 768: <groupId>org.reflections</groupId> Line 769: <artifactId>reflections</artifactId> Line 770: <moduleName>org.reflections</moduleName> Line 771: </module> http://gerrit.ovirt.org/#/c/34814/32/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java: Line 78: @Before Line 79: public void before() { Line 80: AsyncTaskDAO asyncTaskDao = mock(AsyncTaskDAO.class); Line 81: when(asyncTaskDao.getAll()).thenReturn(Collections.EMPTY_LIST); Line 82: when(DbFacade.getInstance().getAsyncTaskDao()).thenReturn(asyncTaskDao); afaik static access cannot be mocked with mockito, and since this class extends CommonCodeTest, it should probably refer to 'dbFacade' which is already defined there. Line 83: CommandEntityDao cmdEntityDao = mock(CommandEntityDao.class); Line 84: when(DbFacade.getInstance().getCommandEntityDao()).thenReturn(cmdEntityDao); Line 85: when(cmdEntityDao.getAll()).thenReturn(Collections.EMPTY_LIST); Line 86: } -- To view, visit http://gerrit.ovirt.org/34814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9e57710ce8353af020cb5ae53e43b127276d6c6 Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
