Sandro Bonazzola has posted comments on this change. Change subject: packaging: bin: Use engine's java-home for classpath ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36669/2/packaging/bin/dwh-classpath.sh File packaging/bin/dwh-classpath.sh: Line 22: *) die "Invalid usage";; Line 23: esac Line 24: Line 25: if [ -z "${JAVA_HOME}" ]; then Line 26: JAVA_HOME=$(/usr/share/ovirt-engine/bin/java-home) maybe better JAVA_HOME="$(/usr/share/ovirt-engine/bin/java-home)" Line 27: export JAVA_HOME Line 28: fi Line 29: Line 30: if [ -x /usr/bin/java-config ]; then -- To view, visit http://gerrit.ovirt.org/36669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9fabfc09629a6f188526e836badc5508752156 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
