Idan Shaby has posted comments on this change. Change subject: webadmin: Configurable Default for Wipe After Delete per Storage Domain ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/36526/5/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetStorageDomainWipeAfterDeleteQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetStorageDomainWipeAfterDeleteQueryTest.java: Line 21: @Before Line 22: @Override Line 23: public void setUp() throws Exception { Line 24: super.setUp(); Line 25: mcr.mockConfigValue(ConfigValues.SANWipeAfterDelete, true); > There's a race between this patch and http://gerrit.ovirt.org/#/c/36539/. NP Line 26: } Line 27: Line 28: @DataPoints Line 29: public static StorageType[] types = StorageType.values(); http://gerrit.ovirt.org/#/c/36526/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml: Line 6: Line 7: <ui:with field='resources' type='org.ovirt.engine.ui.webadmin.ApplicationResources' /> Line 8: <ui:style type="org.ovirt.engine.ui.webadmin.section.main.view.popup.storage.StoragePopupView.WidgetStyle"> Line 9: .content { Line 10: overflow-x: hidden; > can you try without it again, seems to look fine now... I tried it again without it, but then if you choose Data/iSCSI on the Import Domain window, things get ugly. Any other idea? Line 11: } Line 12: Line 13: .formatContentWidget { Line 14: width: 80px; -- To view, visit http://gerrit.ovirt.org/36526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bf6a95eb4b33867de86e99f8cb59eec0d1cdd4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
