Vojtech Szocs has posted comments on this change. Change subject: packaging: add gwt symbols packages ......................................................................
Patch Set 1: Code-Review+1 Looks good it's basically +2 from me, but I am not a specfile expert :-) Some comments: > separate packages as these files are huge and in most cases are not required. +1 > also if we add a feature to decipher stack trace on the fly, we can ask a > customer to install these packages so they will be available for engine. Agreed, JS stacktrace de-obfuscation feature will require "debuginfo" package for given GWT application (webadmin or userportal) installed. Otherwise, GUI will simply not support this feature (and can prompt user to install appropriate "debuginfo" package). Note that this is already covered by RFE BZ: https://bugzilla.redhat.com/1179897 > If the hash is not important better we use static name, it will be easier to > load it when you add the engine part. The <hash> in <hash>.symbolMap is very important, because <hash> is GWT permutation strong name -> basically MD5 hash of all source content. The <hash> must correspond with actual GWT permutation files <hash>.cache.html and with GWT RPC policy files <hash>.gwt.rpc (both of them are inside WAR of given GWT application). So please do NOT rename symbol map files, because GWT StackTraceDeobfuscator utility will read them based on GWT permutation strong name. -- To view, visit http://gerrit.ovirt.org/36655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c5fe0de24a83e2ce49c27f6ac4387d96256ca18 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
