Oved Ourfali has posted comments on this change.

Change subject: Update only name and address fields when picking foreman 
parameters
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/36550/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java:

Line 98:             ExternalHostGroup dhg = (ExternalHostGroup) 
getExternalHostGroups().getSelectedItem();
Line 99:             if (dhost != null && dhg != null) {
Line 100:                 setOriginalName(dhost.getName());
Line 101:                 getName().setEntity(dhost.getName());
Line 102:                 getHost().setEntity(dhost.getName() + "." +
add the //$NON-NLS-1$ in here.
Line 103:                         (dhg.getDomainName() != null ? 
dhg.getDomainName() : "")); //$NON-NLS-1$
Line 104:             }
Line 105:         }
Line 106:     }


-- 
To view, visit http://gerrit.ovirt.org/36550
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7eadb533dd02698f07103fa61e076b46d054522
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to