Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Use hostname for host address ......................................................................
Patch Set 4: Verified+1 pep8, added validation for hostname. Not sure the validation is perfect. I got e.g.: [WARNING] Failed to resolve rhel6-he2.tlv.redhat.com using DNS, it can be resolved only locally Perhaps we should add some note that all hosts hosting the hosted engine should know about each other. But I guess this should be obvious, and our best practices probably say "use dns". -- To view, visit http://gerrit.ovirt.org/36627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a2fc79fe6e57892f0cb9327da1ab8d44b15f29f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
