Arik Hadas has posted comments on this change. Change subject: core: Storage allocation validation fix on new VMs ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36617/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java: Line 397: Collection<DiskImage> disks = new HashSet<>(); Line 398: // Number of added disks multiplies by the vms number Line 399: for (int i = 0; i < numOfVms; ++i) { Line 400: disks.addAll(diskDummies); Line 401: } I'm not sure about this part - let's say I have pool with 3 VMs and then edit the pool and add 3 additional VMs. This code will check if there's enough space for 6 VMs although the disks of 3 VMs already exist, no? Line 402: Line 403: Guid spId = getVmTemplate().getStoragePoolId(); Line 404: Set<Guid> sdIds = destStorages.keySet(); Line 405: MultipleStorageDomainsValidator storageDomainsValidator = getStorageDomainsValidator(spId, sdIds); -- To view, visit http://gerrit.ovirt.org/36617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13f8585a04157a55528ad4331455c3f156bdb84b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
