Martin Peřina has posted comments on this change. Change subject: core: Add unit-tests for fence-proxy selection ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36419/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceProxyLocatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceProxyLocatorTest.java: Line 204: } Line 205: Line 206: @Test Line 207: public void findProxyHost_FencingPolicyNotSupported() { Line 208: FencingPolicy policy = new FencingPolicy(); > See my reply to your previous comment. Well, this doesn't reflect reality, because currently vds.getsupported_cluster_levels() will always return set of all levels from minimal (3.0) to max currently supported (for example 3.5). So now I can finally understand why this test works, but I don't like this approach. But if others are OK with that, let's do it that way ... Line 209: fenceProxyLocator.setFencingPolicy(policy); Line 210: VDS vds = new VDS(); Line 211: vds.setSupportedClusterLevels(Version.v3_1.toString()); Line 212: vds.setId(OTHER_HOST_ID_2); -- To view, visit http://gerrit.ovirt.org/36419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f00b38c78ef7b6a72ee141d9090bf5e60eb679 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
