Gilad Chaplik has posted comments on this change. Change subject: restapi: wrong disk_profile when cloning to another SD ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36591/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java: Line 429: && disk.getStorageDomains().getStorageDomains().get(0).isSetId() Line 430: && !ObjectUtils.equals(disk.getStorageDomains().getStorageDomains().get(0).getId(), Line 431: templateDisk.getStorageIds().get(0))) { Line 432: templateDisk.setDiskProfileId(null); Line 433: } > Can we move this logic to the backend? in the backend side I don't know whether disk profile is set. Line 434: disksMap.put(templateDisk.getId(), map(disk, templateDisk)); Line 435: } else { Line 436: throw new WebApplicationException(Response.Status.NOT_FOUND); Line 437: } -- To view, visit http://gerrit.ovirt.org/36591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f59d31d963e226d2da21751b185714fd57763f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
