Sahina Bose has posted comments on this change. Change subject: engine: Bll to resume geo-rep session ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/32935/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommand.java: Line 17: super(params); Line 18: } Line 19: Line 20: @Override Line 21: protected void setActionMessageParameters() { super.setActionMessageParameters(); Line 22: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__RESUME); Line 23: } Line 24: Line 25: @Override Line 37: Line 38: @Override Line 39: protected void executeCommand() { Line 40: GlusterGeoRepSession session = getGeoRepSession(); Line 41: VDSReturnValue returnValue = runVdsCommand(VDSCommandType.ResumeGeoRepSession, new GlusterVolumeGeoRepSessionVDSParameters(upServer.getId(), session.getMasterVolumeName(), session.getSlaveHostName(), session.getSlaveVolumeName(), parameters .isForce())); please format Line 42: setSucceeded(returnValue.getSucceeded()); Line 43: if(!getSucceeded()) { Line 44: handleVdsError(AuditLogType.GLUSTER_VOLUME_GEO_REP_RESUME_FAILED, returnValue.getVdsError().getMessage()); Line 45: return; -- To view, visit http://gerrit.ovirt.org/32935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8a94c84758d89096c8726b9c11d5d0990a7002 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
