Eliraz Levi has posted comments on this change. Change subject: webadmin: adding sync column to subtab net host ......................................................................
Patch Set 4: (5 comments) http://gerrit.ovirt.org/#/c/35697/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQuery.java: Line 38: for (final VdsNetworkInterface vdsNetworkInterface : vdsNetworkInterfaceList) { Line 39: vdsInterfaceVdsPairs.add(new PairQueryable<VdsNetworkInterface, VDS>(vdsNetworkInterface, Line 40: vdsById.get(vdsNetworkInterface.getVdsId()))); Line 41: Line 42: vdsNetworkInterface.setNetworkImplementationDetails(NetworkUtils.calculateNetworkImplementationDetails(network, > This doesn't look formatted?... The indentation is different from line 39. Done Line 43: qos, Line 44: vdsNetworkInterface)); Line 45: Line 46: } http://gerrit.ovirt.org/#/c/35697/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java: Line 84: private void setupVdsNetworkInterfaceDao() { Line 85: when(getDbFacadeMockInstance().getInterfaceDao()).thenReturn(vdsNetworkInterfaceDaoMock); Line 86: List<VdsNetworkInterface> expectedVdsNetworkInterface = Collections.singletonList(vdsNetworkInterface); Line 87: when(vdsNetworkInterfaceDaoMock.getVdsInterfacesByNetworkId(networkId)).thenReturn( Line 88: expectedVdsNetworkInterface); > Why did you have to change the order of the lines here?... Done Line 89: } Line 90: Line 91: private void setupHostNetworkQosDao(){ Line 92: when(getDbFacadeMockInstance().getHostNetworkQosDao()).thenReturn(hostNetworkQosDao); Line 89: } Line 90: Line 91: private void setupHostNetworkQosDao(){ Line 92: when(getDbFacadeMockInstance().getHostNetworkQosDao()).thenReturn(hostNetworkQosDao); Line 93: when(hostNetworkQosDao.get(networkMocked.getQosId())).thenReturn(hostNetworkQos); > If you're going to mock the QoS entity, then please mock it properly - gene Done Line 94: } Line 95: Line 96: private void setupNetworkDao() { Line 97: when(getDbFacadeMockInstance().getNetworkDao()).thenReturn(networkDaoMock); Line 95: Line 96: private void setupNetworkDao() { Line 97: when(getDbFacadeMockInstance().getNetworkDao()).thenReturn(networkDaoMock); Line 98: when(networkDaoMock.get(networkId)).thenReturn((networkMocked)); Line 99: when(networkMocked.getQosId()).thenReturn(null); > And here return the proper ID as well - you're trying to mimic real behavio Done Line 100: } Line 101: http://gerrit.ovirt.org/#/c/35697/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java: Line 128: private final WebAdminImageResourceColumn<PairQueryable<VdsNetworkInterface, VDS>> hostOutOfSync = new WebAdminImageResourceColumn<PairQueryable<VdsNetworkInterface, VDS>>(){ Line 129: Line 130: @Override Line 131: public ImageResource getValue(PairQueryable<VdsNetworkInterface, VDS> object) { Line 132: return (object.getFirst() ==null || object.getFirst().getNetworkImplementationDetails().isInSync())? null:resources.networkNotSyncImage(); > As usual, this isn't formatted. Done Line 133: } Line 134: Line 135: }; Line 136: -- To view, visit http://gerrit.ovirt.org/35697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd5d3a1e799d8ec0c8f8cea2d4ff7257d0234c2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
