Vojtech Szocs has posted comments on this change. Change subject: webadmin: Fix UI plugin REST API HttpSession refresh issue ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/36622/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java: Line 23: public static final String HEADER_WWW_AUTHENTICATE = "WWW-Authenticate"; Line 24: public static final String HEADER_PREFER = "Prefer"; Line 25: public static final String HEADER_JSESSIONID_COOKIE = "JSESSIONID"; Line 26: public static final String HEADER_ENGINE_AUTH_TOKEN = "OVIRT-INTERNAL-ENGINE-AUTH-TOKEN"; Line 27: public static final String HEADER_ENGINE_REFRESH = "X-OVIRT-INTERNAL-ENGINE-REFRESH"; > None of the other heads are X-something, so I don't think this one should b Indeed. Anyway, to reduce the code change to essential miniumum, I'll remove the "refresh-only" filter in next patchset. Line 28: } Line 29: Line 30: public static final int PREFER_NEW_AUTH = (1<<0); Line 31: public static final int PREFER_PERSISTENCE_AUTH = (1<<1); http://gerrit.ovirt.org/#/c/36622/1/backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml File backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml: Line 125: </filter> Line 126: <filter-mapping> Line 127: <filter-name>RefreshSessionFilter</filter-name> Line 128: <url-pattern>/*</url-pattern> Line 129: </filter-mapping> > I think this filter should be the 1st. Indeed. Anyway, to reduce the code change to essential miniumum, I'll remove the "refresh-only" filter in next patchset. Line 130: Line 131: <!-- confidentiality --> Line 132: <security-constraint> Line 133: <web-resource-collection> http://gerrit.ovirt.org/#/c/36622/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java: Line 167: RequestBuilder createKeepAliveRequest() { Line 168: RequestBuilder builder = createRequest(); Line 169: Line 170: // This request shouldn't do anything other than refresh the REST API session Line 171: builder.setHeader(ENGINE_REFRESH_HEADER, "refresh-only"); //$NON-NLS-1$ > so probably good to check the value at server side and perform refresh only Indeed. Anyway, to reduce the code change to essential miniumum, I'll remove the "refresh-only" filter in next patchset. Line 172: Line 173: return builder; Line 174: } Line 175: -- To view, visit http://gerrit.ovirt.org/36622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ffd3198239040f67313238a837af98db16e79ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
