Yair Zaslavsky has uploaded a new change for review. Change subject: core: Adding missing CTOR to command (#846733) ......................................................................
core: Adding missing CTOR to command (#846733) https://bugzilla.redhat.com/846733 AddImageFromScratchCommand is missing a CTOR which is required for compensation upon server restart (as described in the bug scenario) Change-Id: Ife629f861c1dfa9e0ab57392b77a09d79fe65d41 Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 3 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/63/7363/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java index 0a5396b..34975d4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java @@ -33,6 +33,10 @@ setVmId(getParameters().getMasterVmId()); } + protected AddImageFromScratchCommand(Guid commandId) { + super(commandId); + } + @Override protected void executeCommand() { setImageGroupId(getParameters().getDiskInfo().getId()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java index a990b18..99e6fc4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java @@ -44,6 +44,10 @@ } } + protected BaseImagesCommand(Guid commandId) { + super(commandId); + } + protected void initContainerDetails(ImagesContainterParametersBase parameters) { super.setVmId(parameters.getContainerId()); if (getDiskImage() != null && getDiskImage().getstorage_pool_id() != null) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java index 83d5088..c11839b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java @@ -35,6 +35,10 @@ public class CreateSnapshotCommand<T extends ImagesActionsParametersBase> extends BaseImagesCommand<T> { protected DiskImage mNewCreatedDiskImage; + protected CreateSnapshotCommand(Guid commandId) { + super(commandId); + } + public CreateSnapshotCommand(T parameters) { super(parameters); setSnapshotName(parameters.getDescription()); -- To view, visit http://gerrit.ovirt.org/7363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife629f861c1dfa9e0ab57392b77a09d79fe65d41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
