Michael Kublin has posted comments on this change.
Change subject: core: replace Date with long for time variable
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 597: */
Line 598: public boolean handleNetworkException(VDSNetworkException ex, VDS
vds) {
Line 599: if (vds.getstatus() != VDSStatus.Down) {
Line 600: if (mUnrespondedAttempts.get() < Config.<Integer>
GetValue(ConfigValues.VDSAttemptsToResetCount)
Line 601: || lastUpdate + (Config.<Integer>
GetValue(ConfigValues.TimeoutToResetVdsInSeconds) * 1000) >
System.currentTimeMillis()) {
Please use TimeUnit.convert instead of custom converter
Line 602: boolean result = false;
Line 603: if (vds.getstatus() != VDSStatus.Connecting &&
vds.getstatus() != VDSStatus.PreparingForMaintenance
Line 604: && vds.getstatus() !=
VDSStatus.NonResponsive) {
Line 605: setStatus(VDSStatus.Connecting, vds);
--
To view, visit http://gerrit.ovirt.org/7245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50473b6fddaf06f2cedffb2a7c45a8507c1a7014
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
