Eli Mesika has posted comments on this change. Change subject: core: adjusts default_display_type ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36609/2/packaging/dbscripts/upgrade/03_06_0710_adjust_default_display_type.sql File packaging/dbscripts/upgrade/03_06_0710_adjust_default_display_type.sql: Line 13: from vm_device Line 14: where vm_device.vm_id = vm_static.vm_guid and vm_device.type = 'video'; Line 15: Line 16: drop function device_to_display_type(varchar) ; Line 17 No need for a function Use update with CASE example : http://stackoverflow.com/questions/5548927/sql-update-with-a-case-statement-do-i-need-to-repeat-the-same-case-multiple-t -- To view, visit http://gerrit.ovirt.org/36609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63b268619065fef638349d95bef22bc0ce34c9b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
