Jakub Niedermertl has posted comments on this change. Change subject: userportal, webadmin: New typeahead searching for template comboboxs ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36586/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/SuggestionMatcher.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/SuggestionMatcher.java: Line 11: * @param replacementString one line string representing suggestion in selected state Line 12: * @param displayString html string representing suggestion in suggestion list (eg. generated by {@link org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget#typeAheadNameDescriptionTemplateNullSafe(java.lang.String, java.lang.String)}) Line 13: * @return is suggestion matching Line 14: */ Line 15: public boolean match(String query, String replacementString, String displayString); > I don't see the displayString to be used. Do you need it? Good point, strings merged into MultiWordSuggestion Line 16: Line 17: /** Line 18: * Case independent matcher. Suggestion matches if replacementString starts with query. Line 19: */ -- To view, visit http://gerrit.ovirt.org/36586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7cff48cfd25fe1a121d6710579aafc7b7cf72e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
