Eli Mesika has posted comments on this change. Change subject: core: fix PM settings in new host ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36584/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java: Line 284: } Line 285: DbFacade.getInstance().getVdsStaticDao().save(getParameters().getVdsStaticData()); Line 286: getCompensationContext().snapshotNewEntity(getParameters().getVdsStaticData()); Line 287: setVdsIdRef(getParameters().getVdsStaticData().getId()); Line 288: addFenceAgents(); > Don't we need to save fencing agents using compensation framework same as V The fence agents are stored as a collection in VDS In case of compensation, the host will be restored with an empty list of agents Line 289: setVds(null); Line 290: } Line 291: Line 292: private void AddVdsDynamicToDb() { -- To view, visit http://gerrit.ovirt.org/36584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13ebea573105b7e8f6f8e7a33251e40ec11c165b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
