Sahina Bose has posted comments on this change. Change subject: engine : Bll to pause geo-rep session ......................................................................
Patch Set 6: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/32667/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java: Line 34: VDS slaveVds = getVdsDAO().getByName(parameters.getSlaveHost()); Line 35: if(slaveVds != null) { Line 36: GlusterVolumeEntity slaveVolumeEntity = getGlusterVolumeDao().getByName(slaveVds.getVdsGroupId(), parameters.getSlaveVolumeName()); Line 37: return (slaveVolumeEntity == null ? false : slaveVolumeEntity.getStatus() == GlusterStatus.UP) Line 38: && (masterVolume.getAdvancedDetails().getCapacityInfo().getFreeSize() < slaveVolumeEntity.getAdvancedDetails().getCapacityInfo().getFreeSize()); not required to check size for pause Line 39: } else { Line 40: // Host may not be monitored by ovirt. Line 41: return true; Line 42: } Line 44: return false; Line 45: } Line 46: } else { Line 47: if(getGeoRepSession().getStatus() == GeoRepSessionStatus.PASSIVE) { Line 48: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_GEOREP_SESSION_PAUSED); addFailCanDoAction.. Line 49: } Line 50: return false; Line 51: } Line 52: } http://gerrit.ovirt.org/#/c/32667/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 308: GLUSTER_VOLUME_PROFILE_START_FAILED(4023, AuditLogSeverity.ERROR), Line 309: GLUSTER_VOLUME_PROFILE_STOP(4024), Line 310: GLUSTER_VOLUME_PROFILE_STOP_FAILED(4025, AuditLogSeverity.ERROR), Line 311: GLUSTER_VOLUME_GEO_REP_PAUSE(4596), Line 312: GLUSTER_VOLUME_GEO_REP_PAUSE_FAILED_EXCEPTION(4597, AuditLogSeverity.ERROR), GLUSTER_VOLUME_GEO_REP_PAUSE_FAILED will do Line 313: GLUSTER_VOLUME_CREATED_FROM_CLI(4026, AuditLogSeverity.WARNING), Line 314: GLUSTER_VOLUME_DELETED_FROM_CLI(4027, AuditLogSeverity.WARNING), Line 315: GLUSTER_VOLUME_OPTION_SET_FROM_CLI(4028, AuditLogSeverity.WARNING), Line 316: GLUSTER_VOLUME_OPTION_RESET_FROM_CLI(4029, AuditLogSeverity.WARNING), http://gerrit.ovirt.org/#/c/32667/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 90: VAR__ACTION__HOT_UNPLUG, Line 91: VAR__ACTION__LOGON, Line 92: VAR__ACTION__LOGOFF, Line 93: VAR__ACTION__REBALANCE_START, Line 94: VAR_ACTION_GLUSTER_VOLUME_GEO_REP_PAUSE, VAR__ACTION__PAUSE ? Line 95: VAR__ACTION__REBALANCE_STOP, Line 96: VAR__ACTION__REMOVE_BRICKS_START, Line 97: VAR__ACTION__ASSIGN, Line 98: VAR__ACTION__START_PROFILE, http://gerrit.ovirt.org/#/c/32667/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1293: public StatusOnlyReturnForXmlRpc glusterVolumeGeoRepPause(String masterVolumeName, String slaveHost, String slaveVolumeName, boolean force) { Line 1294: JsonRpcRequest request = new RequestBuilder("GlusterVolume.geoRepPause").withParameter("volumeName", masterVolumeName) Line 1295: .withParameter("remoteHost", slaveHost) Line 1296: .withParameter("remoteVolumeName", slaveVolumeName) Line 1297: .withParameter("force", force).build(); Why is this change here? Line 1298: Map<String, Object> response = new FutureMap(this.client, request); Line 1299: return new StatusOnlyReturnForXmlRpc(response); Line 1300: } Line 1301: -- To view, visit http://gerrit.ovirt.org/32667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38a0ecc89fa55b607a34468075825a5604d7a59a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
