Sahina Bose has posted comments on this change. Change subject: engine : Bll command to start geo-rep session ......................................................................
Patch Set 11: Code-Review+1 (1 comment) Minor comment http://gerrit.ovirt.org/#/c/32537/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 48: VAR__TYPE__GLUSTER_SERVER, Line 49: VAR__TYPE__GLUSTER_HOOK, Line 50: VAR__TYPE__GLUSTER_SERVICE, Line 51: VAR__TYPE__GLUSTER_GEOREP_SESSION, Line 52: VAR_ACTION_GEO_REP_START, Can you put this along with the VAR_ACTIONs? Btw, won't VAR__ACTION__START suffice? Line 53: Line 54: // External Event Line 55: VAR__TYPE__EXTERNAL_EVENT, Line 56: -- To view, visit http://gerrit.ovirt.org/32537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib74c515d23218bb2e30403e0e0042c84b74dc2bb Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
