anmolbabu has posted comments on this change.

Change subject: engine : Query to fetch list of volumes eligible for geo 
replication
......................................................................


Patch Set 26:

(1 comment)

http://gerrit.ovirt.org/#/c/33845/26/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java:

Line 43:     private List<GlusterVolumeEntity> 
getAllGlusterVolumesWithMasterCompatibleVersion(Guid masterVolumeId) {
Line 44:         GlusterVolumeEntity masterVolume = 
getGlusterVolumeDao().getById(masterVolumeId);
Line 45:         VDSGroup masterCluster = 
getVdsGroupDao().get(masterVolume.getClusterId());
Line 46:         List<VDSGroup> clusters = 
getVdsGroupDao().getClustersByServiceAndCompatibilityVersion(true, false, 
masterCluster.getcompatibility_version().getValue());
Line 47:         List<GlusterVolumeEntity> volumes = new 
ArrayList<GlusterVolumeEntity>();
> Why not using the diamond operator? i.e  new ArrayList<>  ?
Done
Line 48:         if(clusters != null) {
Line 49:             for(VDSGroup currentCluster : clusters) {
Line 50:                 
if(!currentCluster.getId().equals(masterCluster.getId())) {
Line 51:                     
volumes.addAll(getGlusterVolumeDao().getByClusterId(currentCluster.getId()));


-- 
To view, visit http://gerrit.ovirt.org/33845
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to