Liran Zelkha has posted comments on this change. Change subject: core: make DbFacade a CDI singleton ......................................................................
Patch Set 29: (3 comments) http://gerrit.ovirt.org/#/c/34814/29/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java: Line 16: public class StorageQosDaoTest extends BaseDAOTestCase { Line 17: Line 18: private StorageQosDao dao; Line 19: Line 20: @Override > that's odd, shouldn't we have a @before annotation here? Done Line 21: public void setUp() throws Exception { Line 22: super.setUp(); Line 23: dao = getDbFacade().getStorageQosDao(); Line 24: } http://gerrit.ovirt.org/#/c/34814/29/ear/src/main/resources/META-INF/MANIFEST.MF File ear/src/main/resources/META-INF/MANIFEST.MF: Line 1: Manifest-Version: 1.0 Line 2: Dependencies: asm.asm, Line 3: com.google.guava, > why do we need guava? will we have any issues with packaging, I mean.. will We need it as it's a dependency of deltaspike Line 4: javax.validation.api, Line 5: org.apache.commons.beanutils, Line 6: org.apache.commons.codec, Line 7: org.apache.commons.collections, Line 10: org.apache.httpcomponents, Line 11: org.apache.xmlrpc, Line 12: org.codehaus.jackson.jackson-core-asl, Line 13: org.codehaus.jackson.jackson-mapper-asl, Line 14: org.deltaspike, > same about deltaspike Must have for the extension I wrote. Once we upgrade to jboss 7.1.2 - we can drop it Line 15: org.dom4j, Line 16: org.hibernate.validator, Line 17: org.infinispan, Line 18: org.ovirt.engine.core.common, -- To view, visit http://gerrit.ovirt.org/34814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9e57710ce8353af020cb5ae53e43b127276d6c6 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
