Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Host Intrfaces menu doesn't change by DC version (#838491) ......................................................................
webadmin: Host Intrfaces menu doesn't change by DC version (#838491) https://bugzilla.redhat.com/838491 The setEntity in HostIntefaceListModel was overriden and did nothing if the entityId didn't change. That's why the HostInterfaceModel remained with old dc/cluster data and the actions weren't updated correctly. Change-Id: I4ab206aa7272ebc87d0df66ab402347a118c545e Signed-off-by: Alona Kaplan <alkap...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 0 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/7351/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java index ab54086..8faf0fc 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java @@ -164,25 +164,6 @@ return (VDS) super.getEntity(); } - public void setEntity(VDS value) - { - if (super.getEntity() != null) - { - VDS currentItem = ((VDS) super.getEntity()); - VDS newItem = value; - - Guid currentItemId = currentItem.getId().getValue(); - Guid newItemId = newItem.getId().getValue(); - - if (currentItemId.equals(newItemId)) - { - return; - } - } - - super.setEntity(value); - } - private ArrayList<VdsNetworkInterface> GetSelectedItems(boolean withVlans) { ArrayList<VdsNetworkInterface> list = new ArrayList<VdsNetworkInterface>(); -- To view, visit http://gerrit.ovirt.org/7351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ab206aa7272ebc87d0df66ab402347a118c545e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
