[Engine-patches] Change in ovirt-engine[master]: ui: notification to the user that a new client tools are ava...

[shavivi]

Shahar Havivi has uploaded a new change for review.

Change subject: ui: notification to the user that a new client tools are 
available
......................................................................

ui: notification to the user that a new client tools are available

When new guest tools are available we indicate that by annotating the
VMs running icon with annotation mark and a tooltip

Change-Id: I855aa69a1d91967bde6f784e494bf4a343c78576
Signed-off-by: Shahar Havivi <shah...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java
2 files changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/36580/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
index c2fbb07..4d0393f 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
@@ -1703,6 +1703,9 @@
     @DefaultStringValue("Down")
     String down();
 
+    @DefaultStringValue("New guest tools are available")
+    String newtools();
+
     @DefaultStringValue("Up but one or more bricks are down")
     String volumeBricksDown();
 
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java
index 6c66c90..7da5ca6 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java
@@ -1,5 +1,6 @@
 package org.ovirt.engine.ui.webadmin.widget.table.column;
 
+import org.ovirt.engine.core.common.businessentities.GuestAgentStatus;
 import org.ovirt.engine.core.common.businessentities.VM;
 import org.ovirt.engine.core.common.businessentities.VMStatus;
 import org.ovirt.engine.core.common.businessentities.VmPauseStatus;
@@ -39,6 +40,10 @@
             if (vm.isRunOnce()) {
                 tooltip = constants.runOnce();
                 statusImage = resources.runOnceUpImage();
+            } else if (vm.getGuestAgentStatus() == 
GuestAgentStatus.UpdateNeeded) {
+                tooltip = constants.newtools();
+                //TODO: need a new icon
+                statusImage = resources.vmStatusRunning();
             } else {
                 tooltip = constants.up();
                 statusImage = resources.vmStatusRunning();


-- 
To view, visit http://gerrit.ovirt.org/36580
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I855aa69a1d91967bde6f784e494bf4a343c78576
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches