Ori Liel has uploaded a new change for review. Change subject: BZ1178023 - Change LinkedList to ArrayList in Vds DAO ......................................................................
BZ1178023 - Change LinkedList to ArrayList in Vds DAO This change is necessary because some client implementation (wrongly) assumes the the return type is ArrayList Bug-Url: http://bugzilla.redhat.com/1178023 Change-Id: Ic3d7efc4c1e53696546f59e6113f13fce4b432fd Signed-off-by: Ori Liel <ol...@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/36574/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java index 2f083df..5668d30 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java @@ -6,7 +6,6 @@ import java.util.Collections; import java.util.Comparator; import java.util.HashMap; -import java.util.LinkedList; import java.util.List; import java.util.Map; import java.util.Map.Entry; @@ -397,7 +396,7 @@ } private VDS uniteAgentsSingleVds(List<VDS> vdsList) { - List<FenceAgent> agents = new LinkedList<>(); + List<FenceAgent> agents = new ArrayList<>(); for (VDS vds : vdsList) { // collect agents from all rows agents.addAll(vds.getFenceAgents()); } @@ -410,7 +409,7 @@ Map<Guid, List<VDS>> map = new HashMap<>(); for (VDS vds : vdsList) { if (!map.containsKey(vds.getId())) { - map.put(vds.getId(), new LinkedList<VDS>()); + map.put(vds.getId(), new ArrayList<VDS>()); } map.get(vds.getId()).add(vds); } @@ -419,7 +418,7 @@ private List<VDS> uniteAgents(List<VDS> vdsList) { Map<Guid, List<VDS>> vdsMap = getVdsMap(vdsList); - List<VDS> results = new LinkedList<>(); + List<VDS> results = new ArrayList<>(); for (Entry<Guid, List<VDS>> entry : vdsMap.entrySet()) { results.add(uniteAgentsSingleVds(entry.getValue())); } -- To view, visit http://gerrit.ovirt.org/36574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic3d7efc4c1e53696546f59e6113f13fce4b432fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
