Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL command for volume snapshot create ......................................................................
Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/34928/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java: Line 68: handleVdsError(AuditLogType.GLUSTER_VOLUME_SNAPSHOT_CREATE_FAILED, retVal.getVdsError().getMessage()); Line 69: } else { Line 70: GlusterVolumeSnapshotEntity createdSnapshot = getParameters().getSnapshot(); Line 71: createdSnapshot.setSnapshotId(((GlusterVolumeSnapshotEntity) retVal.getReturnValue()).getSnapshotId()); Line 72: createdSnapshot.setCreatedAt(new Date()); > Do we need to set this explicitly? I think in database, it defaults to curr yes. set default is localtimestamp. will try that. Line 73: createdSnapshot.setStatus(GlusterSnapshotStatus.STARTED); Line 74: getDbFacade().getGlusterVolumeSnapshotDao().save(createdSnapshot); Line 75: } Line 76: } Line 92: return false; Line 93: } Line 94: Line 95: GlusterVolumeEntity volume = getGlusterVolumeDao().getById(volumeId); Line 96: if (volume != null && volume.getStatus() == GlusterStatus.DOWN) { > What if volume is null? will add check for this scenario Line 97: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_IS_DOWN); Line 98: } Line 99: Line 100: if (!isVolumeThinlyProvisioned(volume)) { http://gerrit.ovirt.org/#/c/34928/11/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 808: GLUSTER_VOLUME_BRICK_ADDED=Brick [${brickpath}] on host [${servername}] added to volume [${glusterVolumeName}] Line 809: GLUSTER_BRICK_STATUS_CHANGED=Detected change in status of brick ${brickpath} of volume ${glusterVolumeName} from ${oldValue} to ${newValue}. Line 810: GLUSTER_GEOREP_SESSION_DELETED_FROM_CLI=Detected deletion of geo-replication session ${geoRepSessionKey} from volume ${glusterVolumeName} Line 811: GLUSTER_GEOREP_SESSION_DETECTED_FROM_CLI=Detected new geo-replication session ${geoRepSessionKey} for volume ${glusterVolumeName}. Adding it to engine. Line 812: GLUSTER_VOLUME_SNAPSHOT_CREATED=Snapshot ${snapname} create for volume ${glusterVolumeName}. > created done Line 813: GLUSTER_VOLUME_SNAPSHOT_CREATE_FAILED=Could not create ${snapname} for volume ${glusterVolumeName}. Line 814: VDS_UNTRUSTED=Host ${VdsName} was set to non-operational. Host is not trusted by the attestation service. Line 815: USER_ADDED_NETWORK_QOS=Network QoS ${QosName} was added. (User: ${UserName}) Line 816: USER_FAILED_TO_ADD_NETWORK_QOS=Failed to add Network QoS ${QosName}. (User: ${UserName}) -- To view, visit http://gerrit.ovirt.org/34928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c27f9e73bac8d6de3022b0dd4e70aa0d8b1494b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
