Shubhendu Tripathi has posted comments on this change. Change subject: gluster: DAO for volume snapshot maintenance ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/23372/11/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDaoTest.java: Line 112: assertTrue(snapshots.isEmpty()); Line 113: } Line 114: Line 115: @Test Line 116: public void testUpdateVolumeStatus() { > testUpdateSnapshotStatus oh yes. my misatke. will correct it Line 117: dao.updateSnapshotStatus(existingSnapshot.getSnapshotId(), GlusterSnapshotStatus.STOPPED); Line 118: GlusterVolumeSnapshotEntity snapshot = dao.getById(existingSnapshot.getSnapshotId()); Line 119: Line 120: assertNotNull(snapshot); http://gerrit.ovirt.org/#/c/23372/11/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 6828: <value>0c3f45f6-3fe9-4b35-a30c-be0d1a835ea6</value> Line 6829: <value>0c3f45f6-3fe9-4b35-a30c-be0d1a835ea8</value> Line 6830: <value>test-vol-distribute-1-snap1</value> Line 6831: <value></value> Line 6832: <value>ACTIVATED</value> > I see 'STARTED/STOPPED' in DaoTest class. Which is the right one? STARTED / STOPPED is correct one. Will modify and verify the test cases. Line 6833: </row> Line 6834: <row> Line 6835: <value>0c3f45f6-3fe9-4b35-a30c-be0d1a835ea7</value> Line 6836: <value>0c3f45f6-3fe9-4b35-a30c-be0d1a835ea8</value> -- To view, visit http://gerrit.ovirt.org/23372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id60902aad02b852773ad398aaac9bad8ed7793ab Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Nishanth Thomas <nishusem...@gmail.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
