Lior Vernia has submitted this change and it was merged. Change subject: engine,webadmin: Minimize usage of "new VdsNetworkInterface()" ......................................................................
engine,webadmin: Minimize usage of "new VdsNetworkInterface()" Tried to replace existing calls with calls to the more specific subclasses. Remaining invocations (excluding test code) are an edge case that can't be ruled out in InterfaceDaoDbFacadeImpl, and some code that should be removed in the not-so-distant future in HostSetupNetworksModel. Change-Id: Ie00542f8af75fa3a0a7fde599f4260d7835005a0 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 3 files changed, 8 insertions(+), 31 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie00542f8af75fa3a0a7fde599f4260d7835005a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
