Maor Lipchuk has posted comments on this change. Change subject: core: Block import of storage domain if the storage contains hosted engine ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/36549/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java: Line 67: Line 68: StorageDomainValidator validator = new StorageDomainValidator(getStorageDomain()); Line 69: if (!validate(validator.isHostedEngineStorage())) { Line 70: return false; Line 71: } I would move this before you call getLUNsFromVgInfo (to reduce the vds operation). move this to line 60 Line 72: Line 73: return true; Line 74: } Line 75: http://gerrit.ovirt.org/#/c/36549/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java: Line 68: storageDomainFromIrs.setStorageStaticData(domainFromIrs.getFirst()); Line 69: StorageDomainValidator validator = new StorageDomainValidator(storageDomainFromIrs); Line 70: if (!validate(validator.isHostedEngineStorage())) { Line 71: return false; Line 72: } > Suggestion: I would move this to concreteCheckExistingStorageDomain after l on second thought, why not using only getStorageDomain() for the validator, the name should be initialized there, no? Line 73: Line 74: return concreteCheckExistingStorageDomain(domainFromIrs); Line 75: } Line 76: -- To view, visit http://gerrit.ovirt.org/36549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36db8c4a7a1d13be8874407c56596ecd9ab74333 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
