Allon Mureinik has posted comments on this change. Change subject: core: Limitation addition for downgrading DC's compatible version. ......................................................................
Patch Set 13: Code-Review+1 (3 comments) http://gerrit.ovirt.org/#/c/35790/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidator.java: Line 42: private boolean isStorageDomainOfTypeIsoOrExport() { Line 43: return storageDomainStatic.getStorageDomainType().isIsoOrImportExportDomain(); Line 44: } Line 45: Line 46: Why add a newline here? Line 47: public ValidationResult isStorageDomainTypeSupportedInPool() { Line 48: if (storageDomainStatic.getStorageType() == StorageType.GLUSTERFS) { Line 49: return isGlusterSupportedInDC(); Line 50: } Line 132: } Line 133: Line 134: if (storagePool != null) { Line 135: if (VersionStorageFormatUtil.getPreferredForVersion(storagePool.getcompatibility_version(), Line 136: storageDomainStatic.getStorageType()).compareTo(storageDomainStatic.getStorageFormat()) < 0) { Why is removing a newline here related to the patch? Line 137: return new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL, String.format("$storageFormat %1$s", storageDomainStatic Line 138: .getStorageFormat().toString())); Line 139: } Line 140: } Line 147: } Line 148: return ValidationResult.VALID; Line 149: } Line 150: Line 151: Why add a newline here? Line 152: public ValidationResult isStorageDomainTypeFitsPoolIfMixed() { Line 153: boolean isBlockDomain = storageDomainStatic.getStorageType().isBlockDomain(); Line 154: Line 155: if (!isMixedTypesAllowedInDC()) { -- To view, visit http://gerrit.ovirt.org/35790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib97488c705a32fe73b390ef226b1ad19a3784b76 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
