Kanagaraj M has posted comments on this change. Change subject: gluster: Sync job for gluster volume snapshots ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/35904/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeSnapshotConfigReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeSnapshotConfigReturnForXmlRpc.java: Line 24: super(innerMap); Line 25: status = new StatusForXmlRpc((Map<String, Object>) innerMap.get(STATUS)); Line 26: Line 27: Map<String, Object> systemConfig = (Map<String, Object>) innerMap.get(SYSTEM_CONFIG); Line 28: glusterSnapshotConfigInfo.setClusterId(clusterId); I don't see clusterId being used in sync-job. Is this required? Line 29: Map<String, String> clusterConfigs = new HashMap<String, String>(); Line 30: for (String key : systemConfig.keySet()) { Line 31: String value = (String) systemConfig.get(key); Line 32: clusterConfigs.put(key, value == null ? "" : value); http://gerrit.ovirt.org/#/c/35904/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeSnapshotInfoReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeSnapshotInfoReturnForXmlRpc.java: Line 64: } catch (Exception e) { Line 65: log.error("Could not populate snapshots of volume '{}' on cluster '{}': {}", Line 66: volume.getName(), Line 67: volume.getClusterId(), Line 68: e.getMessage()); This is just a failure in parsing the timestamp and it doesn't affect much. Message should be modified accordingly. Line 69: log.debug("Exception", e); Line 70: } Line 71: newSnapshot.setSnapshotId(Guid.createGuidFromString((String) snapshotInfo.get(UUID))); Line 72: newSnapshot.setSnapshotName((String) snapshotInfo.get(NAME)); -- To view, visit http://gerrit.ovirt.org/35904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b7bf79b72fc5680dab301b290e7aa860d5c714d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
