Juan Hernandez has posted comments on this change.

Change subject: packaging: maven: compile using xmvn
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/36528/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java:

Line 14: import java.util.Map;
Line 15: 
Line 16: import org.apache.commons.configuration.Configuration;
Line 17: import org.apache.commons.configuration.HierarchicalConfiguration;
Line 18: import org.apache.commons.configuration.SubnodeConfiguration;
To avoid checkstyle failures you need to remove this ^ line as well, as it 
isn't used now.
Line 19: import org.apache.commons.configuration.tree.ConfigurationNode;
Line 20: import org.apache.commons.lang.StringUtils;
Line 21: import org.ovirt.engine.core.config.db.ConfigDAO;
Line 22: import org.ovirt.engine.core.config.db.ConfigDaoImpl;


-- 
To view, visit http://gerrit.ovirt.org/36528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41b7448573ccf5b521febb9f716197d18e3108c9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to