Vojtech Szocs has posted comments on this change. Change subject: UI: close button is not closing configure and about dialogue (#839481) ......................................................................
Patch Set 1: Verified; Looks good to me, approved This patch is correct, since both ConfigurePopupPresenterWidget and AboutPopupPresenterWidget are bound as singletons within PresenterModule (using bindSingletonPresenterWidget). -- To view, visit http://gerrit.ovirt.org/7177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eb3c393abf595389790f6d0ec1f3d7b837a6335 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
