Amit Aviram has posted comments on this change.

Change subject: restapi: Enabling connection details editing for ISO & Export 
domains.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36481/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java:

Line 122:     }
Line 123: 
Line 124:     public static synchronized String[] 
getLinksToExclude(StorageDomain storageDomain) {
Line 125:         return isIsoDomain(storageDomain) ? new String[] { 
"templates", "vms", "disks", "images" }
Line 126:                 : isExportDomain(storageDomain) ? new String[] { 
"files", "images" }
> How does this relate to editing ISOs?
It is related to viewing its connection details- which was the bug in the first 
place. I'll change the commit message to describe it better.
Line 127:                         : isImageDomain(storageDomain) ? new String[] 
{ "templates", "vms", "files", "disks",
Line 128:                                 "storageconnections" }
Line 129:                                 : new String[] { "templates", "vms", 
"files", "images" };
Line 130:     }


-- 
To view, visit http://gerrit.ovirt.org/36481
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab555a55899dc10bf7677d6ee5ee1fa4cc91f921
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to