Alona Kaplan has uploaded a new change for review. Change subject: webadmin: can set port mirroring on Edit vnic also for 3.0 (#846025) ......................................................................
webadmin: can set port mirroring on Edit vnic also for 3.0 (#846025) https://bugzilla.redhat.com/846025 Port mirroring should be disabled in Edit vnic dialog if the cluster version is 3.0 or beneath. Change-Id: Icc5c83ce89f03108f6476fd1b8fcdd780543384c Signed-off-by: Alona Kaplan <alkap...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/7335/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java index 2f73114..d1f9bbe 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java @@ -273,6 +273,11 @@ model.getMAC().setIsChangable(false); model.getMAC().setEntity(nic.getMacAddress()); model.getActive().setIsAvailable(false); + + Version v31 = new Version(3, 1); + boolean isLessThan31 = vm.getvds_group_compatibility_version().compareTo(v31) < 0; + + model.getPortMirroring().setIsChangable(!isLessThan31); model.getPortMirroring().setEntity(nic.isPortMirroring()); AsyncQuery _asyncQuery = new AsyncQuery(); -- To view, visit http://gerrit.ovirt.org/7335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icc5c83ce89f03108f6476fd1b8fcdd780543384c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
