Vered Volansky has posted comments on this change. Change subject: core: change storage_domain_static update policy ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/36151/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 1133: getDestroyCommand().setIsAvailable(isAvailable); Line 1134: } Line 1135: Line 1136: private boolean isEditAvailable(StorageDomain storageDomain) { Line 1137: if (storageDomain == null || storageDomain.getStorageDomainSharedStatus() == StorageDomainSharedStatus.Locked) { > use 'model.isStorageNotLocked()' instead Actually, bringing the model here looks bad, unless I'm missing something... Line 1138: return false; Line 1139: } Line 1140: Line 1141: boolean isEditAvailable; -- To view, visit http://gerrit.ovirt.org/36151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dfa97b1dbe047d98f9f1e7f7ec2d53ae5c8a16b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
