Eli Mesika has posted comments on this change. Change subject: engine : Entity and DAO changes for Disk provisioning ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/36428/1/packaging/dbscripts/storage_device_sp.sql File packaging/dbscripts/storage_device_sp.sql: Line 29: v_name VARCHAR(1000), Line 30: v_device_uuid VARCHAR(38), Line 31: v_filesystem_uuid VARCHAR(38), Line 32: v_description VARCHAR(2000), Line 33: v_device_type VARCHAR(50), Please remove TWS Line 34: v_device_path VARCHAR(4096), Line 35: v_filesystem_type VARCHAR(50), Line 36: v_mount_point VARCHAR(4096), Line 37: v_size BIGINT, http://gerrit.ovirt.org/#/c/36428/1/packaging/dbscripts/upgrade/03_06_0590_storage_device_tables.sql File packaging/dbscripts/upgrade/03_06_0590_storage_device_tables.sql: Line 1: -- Add storage_device table Line 2: CREATE TABLE storage_device Line 3: ( Line 4: id UUID NOT NULL, Line 5: name VARCHAR(1000) NOT NULL, Please use 4 spaces instead of TABs Line 6: device_uuid VARCHAR(38) NOT NULL, Line 7: filesystem_uuid VARCHAR(38), Line 8: vds_id UUID NOT NULL, Line 9: description VARCHAR(2000), Line 16: _create_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 17: _update_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 18: CONSTRAINT pk_storage_device PRIMARY KEY(id), Line 19: FOREIGN KEY (vds_id) REFERENCES vds_static(vds_id) ON DELETE CASCADE Line 20: ) WITH OIDS; I saw lot of GetByXXX You should add indexes for that as well in order to prevent table scan -- To view, visit http://gerrit.ovirt.org/36428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
