Liron Aravot has uploaded a new change for review.
Change subject: core: supress findbugs warning in
StorageServerConnectionCommandBase
......................................................................
core: supress findbugs warning in StorageServerConnectionCommandBase
after change I0fc70dd4e7988f4ea4597f016c9de8419c17adfa findbugs
complains about null pointer dereference of connections which is wrong.
Change-Id: I139f33ddba33cfb109145505afc1aea609c82807
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M backend/manager/modules/bll/exclude-filters.xml
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/36430/1
diff --git a/backend/manager/modules/bll/exclude-filters.xml
b/backend/manager/modules/bll/exclude-filters.xml
index 3ec39c0..f88f2c5 100644
--- a/backend/manager/modules/bll/exclude-filters.xml
+++ b/backend/manager/modules/bll/exclude-filters.xml
@@ -21,6 +21,16 @@
<Bug code="RV"/>
</Match>
+ <Match>
+ <!--
+ findbugs complains on possible null dereference that'll cause to a
+ NPE. As the connections varible can't be null that warning is false.
+ -->
+ <Class
name="org.ovirt.engine.core.bll.storage.StorageServerConnectionCommandBase" />
+ <Method name="isConnWithSameDetailsExists"/>
+ <Bug pattern="NP_NULL_ON_SOME_PATH" />
+ </Match>
+
<!--
findbugs complains that class does not call super.clone()
its super class is QuotaConsumptionParameter which is abstract
--
To view, visit http://gerrit.ovirt.org/36430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I139f33ddba33cfb109145505afc1aea609c82807
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
