Liron Aravot has posted comments on this change. Change subject: core: decouple recovery and reconstruct master domain ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/28443/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java: Line 138: getStoragePoolIsoMapDAO().remove(domainPoolMap.getId()); Line 139: } Line 140: Line 141: if (returnVal.getSucceeded()) { Line 142: updateStorageDomainFormat(getNewMasterDomain()); the domain was loaded before reconstruct ran, by running this update you may override properties of the domain that were updated during the reconstruct command. Line 143: } Line 144: Line 145: setSucceeded(returnVal.getSucceeded()); Line 146: return new EventResult(reconstructVerbExecuted, EventType.RECONSTRUCT); -- To view, visit http://gerrit.ovirt.org/28443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c066b9ff4bebce899492fcc8b54bd6a2723b453 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
