Maor Lipchuk has posted comments on this change. Change subject: engine: Send net_ifacename to VDSM when connecting iSCSI server ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/32383/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java: Line 81: Line 82: if (!ifaces.isEmpty()) { Line 83: VdsNetworkInterface vdsNetworkInterface = ifaces.remove(0); Line 84: conn.setIface(vdsNetworkInterface.getName()); Line 85: conn.setNetIfacename(vdsNetworkInterface.isBridged() ? > Done done Line 86: vdsNetworkInterface.getNetworkName() : vdsNetworkInterface.getName()); Line 87: Line 88: // Iscsi target is represented by connection object, therefore if this target is approachable Line 89: // from more than one endpoint(initiator) we have to clone this connection per endpoint. http://gerrit.ovirt.org/#/c/32383/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java: Line 188: public void setIface(String iface) { Line 189: this.iface = iface; Line 190: } Line 191: Line 192: private String netIfacename; > Please use consistent mixedCase names: netIfaceName topLevelNetworkDevice will not be consistent with the VDSM attribute, for now I'm leaving this as netIfaceName Line 193: Line 194: public String getNetIfacename() { Line 195: return netIfacename; Line 196: } Line 190: } Line 191: Line 192: private String netIfacename; Line 193: Line 194: public String getNetIfacename() { > Please use consistent mixedCase names: getNetIfaceName done Line 195: return netIfacename; Line 196: } Line 197: Line 198: public void setNetIfacename(String netIfacename) { Line 194: public String getNetIfacename() { Line 195: return netIfacename; Line 196: } Line 197: Line 198: public void setNetIfacename(String netIfacename) { > Please use consistent mixedCase names: setNetIfaceName done Line 199: this.netIfacename = netIfacename; Line 200: } Line 201: Line 202: @Override http://gerrit.ovirt.org/#/c/32383/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java: Line 78: con.put("iqn", connection.getiqn(), ""); Line 79: con.put("user", connection.getuser_name(), ""); Line 80: con.put("password", connection.getpassword(), ""); Line 81: con.putIfNotEmpty("ifaceName", connection.getIface()); Line 82: con.putIfNotEmpty("netIfacename", connection.getNetIfacename()); > This is not consistent with other argument names. Please use "netIfaceName" done Line 83: Line 84: // storage_pool can be null when discovering iscsi send targets or when connecting Line 85: // through vds which has no storage pool Line 86: if (storagePool == null || Config.<Boolean> getValue(ConfigValues.AdvancedNFSOptionsEnabled, -- To view, visit http://gerrit.ovirt.org/32383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e2f3549fa08741f719eeb8d70209ab298e09da3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
