Allon Mureinik has posted comments on this change. Change subject: core: Check if data center version supports import data domain upon attach ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36363/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 232: // ovfDisks cache list updated. Line 233: List<DiskImage> ovfStoreDiskImages = new ArrayList(getAllOVFDisks()); Line 234: if (!ovfStoreDiskImages.isEmpty()) { Line 235: if (!FeatureSupported.ovfStoreOnAnyDomain(getStoragePool().getcompatibility_version())) { Line 236: AuditLogDirector.log(this, AuditLogType.RETRIEVE_UNREGISTERED_ENTITIES_NOT_SUPPORTED_IN_DC_VERSION); Where is $StorageDomainName set? Line 237: return Collections.emptyList(); Line 238: } Line 239: while (!ovfStoreDiskImages.isEmpty()) { Line 240: Pair<DiskImage, Long> ovfDiskAndSize = getLatestOVFDisk(ovfStoreDiskImages); -- To view, visit http://gerrit.ovirt.org/36363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05b6a8fe737691655dedbfbbb8d1f0ee4a592668 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches