Shahar Havivi has submitted this change and it was merged. Change subject: core: Replace ANTLRv4 with JavaCC in OsInfo validation ......................................................................
core: Replace ANTLRv4 with JavaCC in OsInfo validation A replacement for the ANTLRv4-based validator for the OsInfo properties file. It uses JavaCC instead, this has the following advantages: - Generates code that does not depend on any external dependency - The build dependency is already properly packaged in most distros On the other hand, the syntax for the grammar file is not as clean as the ANTLR version. Change-Id: Ice68f11f4616ab488d4caf7f8073b4b423ab0c46 Signed-off-by: Vitor de Lima <vdel...@redhat.com> --- M backend/manager/dependencies/common/pom.xml D backend/manager/dependencies/common/src/main/modules/org/antlr/antlr4-runtime/main/module.xml M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml D backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4 M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsinfoPropertiesParser.java A backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M pom.xml 9 files changed, 236 insertions(+), 294 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice68f11f4616ab488d4caf7f8073b4b423ab0c46 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
